Repository navigation
chore: Remove unused dependencies - #83
Open
jsonbailey wants to merge 2 commits into
Open
jsonbailey wants to merge 2 commits into
jsonbailey wants to merge 2 commits into
Conversation
jsonbailey
marked this pull request as ready for review
November 4, 2026 23:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dependencies that nothing in this repo uses. The docs entries look copied from python-server-sdk's dependency list.
mock. No code imports themockpackage; tests useunittest.mockand local mock classes.backoff,expiringdict,pyrfc3339,jsonpickle,semver. None is imported by the package, tests, contract tests, ordocs/conf.py, and none is a Sphinx extension.urllib3. It is a runtime dependency, anduv sync --group docsinstalls the project, so the docs build already gets it.Checked imports in
ld_eventsource/,contract-tests/,docs/conf.py, the Makefile, CI workflows, and.readthedocs.yml.make lint,make test(147 passed), andmake docs(Sphinx with-W) all pass.Note
Overview
Trims dependency-groups in
pyproject.tomlso install/sync only pulls packages this repo actually uses.dev: drops
mock(tests rely onunittest.mock, not the standalonemockpackage). docs: removesbackoff,expiringdict,pyrfc3339,jsonpickle,semver, andurllib3from the docs group—none are imported by the library, tests, contract tests, or Sphinx config;urllib3remains a normal runtime dependency and is still available when building docs via the project install.Reviewed by Cursor Bugbot for commit 225fd14. Bugbot is set up for automated code reviews on this repo. Configure here.