Skip to content

chore: Remove unused dependencies - #83

Open
jsonbailey wants to merge 2 commits into
mainfrom
jb/sdk-3466/remove-unused-deps
Open

jsonbailey wants to merge 2 commits into
mainfrom
jb/sdk-3466/remove-unused-deps

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remove dependencies that nothing in this repo uses. The docs entries look copied from python-server-sdk's dependency list.

  • dev: mock. No code imports the mock package; tests use unittest.mock and local mock classes.
  • docs: backoff, expiringdict, pyrfc3339, jsonpickle, semver. None is imported by the package, tests, contract tests, or docs/conf.py, and none is a Sphinx extension.
  • docs: urllib3. It is a runtime dependency, and uv sync --group docs installs the project, so the docs build already gets it.

Checked imports in ld_eventsource/, contract-tests/, docs/conf.py, the Makefile, CI workflows, and .readthedocs.yml. make lint, make test (147 passed), and make docs (Sphinx with -W) all pass.


Note

Overview
Trims dependency-groups in pyproject.toml so install/sync only pulls packages this repo actually uses.

dev: drops mock (tests rely on unittest.mock, not the standalone mock package). docs: removes backoff, expiringdict, pyrfc3339, jsonpickle, semver, and urllib3 from the docs group—none are imported by the library, tests, contract tests, or Sphinx config; urllib3 remains a normal runtime dependency and is still available when building docs via the project install.

Reviewed by Cursor Bugbot for commit 225fd14. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey
jsonbailey marked this pull request as ready for review November 4, 2026 23:57
@jsonbailey
jsonbailey requested a review from a team as a code owner November 4, 2026 23:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant