Repository navigation
test(opencode-agents): make the boot-timeout test robust on slow runners - #212
Open
jeffdupont wants to merge 1 commit into
Open
jeffdupont wants to merge 1 commit into
jeffdupont wants to merge 1 commit into
Conversation
The test gave the stream a 0.2 s timeout after a 0.6 s fake boot. On a slow runner the stream alone can take longer than 0.2 s, so it failed without any bug. A 2.0 s boot against a 1.0 s timeout still fails if the boot moves inside the caller's timeout, and leaves the stream room. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestProcess::test_boot_is_outside_the_caller_timeoutgave the stream a 0.2 s timeout after a 0.6 s fake boot. On a slow runner the stream alone can take more than 0.2 s, so the test failed with no bug present (it failed CI on #201).This raises the fake boot to 2.0 s and the timeout to 1.0 s:
async with handlerin the timeout: the test fails.The test takes about 2.5 s instead of 0.6 s.
🤖 Generated with Claude Code
Note
Overview
Relaxes timing in
test_boot_is_outside_the_caller_timeoutso it stops failing on slow CI when the stream alone exceeds the old 0.2 s budget.The fake OpenCode
delay_readygoes from 0.6 s → 2.0 s, and theasyncio.timeoutaround streaming goes from 0.2 s → 1.0 s. Boot is still longer than the timeout, so the test still catches boot work incorrectly running inside the caller’s timeout; the wider window only gives the stream headroom on sluggish runners. Comments in the test document that intent.Reviewed by Cursor Bugbot for commit 53ea3d2. Bugbot is set up for automated code reviews on this repo. Configure here.