Repository navigation
test: Declare client-event-source-http-errors in the client contract test service - #637
Merged
Merged
Conversation
…test service Generated-by: termag
kinyoklion
marked this pull request as ready for review
November 3, 2026 17:21
beekld
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The client SDK already stops the stream instead of retrying on an unrecoverable HTTP error (401, 403, 405), but the client contract test service did not declare
client-event-source-http-errors, so the harness skipped thestreaming/retry behavior/do not retry after unrecoverable HTTP errortests on initial connect and on reconnect. This declares the capability so those tests run.Tested locally with the Beast build against harness v2.42.0: both groups (401, 403 and 405 each) run and pass, with no regressions.
Opened from termag