Repository navigation
test: Declare the all-flags option capabilities in the server contract test service - #636
Merged
Merged
Conversation
…t test service Generated-by: termag
kinyoklion
marked this pull request as ready for review
November 3, 2026 17:20
keelerm84
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server contract test service already maps the
withReasons,clientSideOnlyanddetailsOnlyForTrackedFlagsoptions ofevaluateAlltoAllFlagsState::Options, but it never declared the matching capabilities, so the harness skipped those tests. This declaresall-flags-with-reasons,all-flags-client-side-onlyandall-flags-details-only-for-tracked-flags, which runs theevaluation/all flags statetests "with reasons", "client-side filter" and "details only for tracked flags" on harness v2 and v3.Tested locally with the Beast build against harness v2.42.0 and v3.2.0-alpha.15 (v3 with the CI suppression file): the three tests run and pass, with no regressions.
Opened from termag