Repository navigation
ci: include contract tests and Redis source in the lint compile database - #633
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cpp-linterjob configured CMake with default options, soLD_BUILD_CONTRACT_TESTSandLD_BUILD_REDIS_SUPPORTwere OFF. As a result,contract-tests/andlibs/server-sdk-redis-source/were missing fromcompile_commands.json. clang-tidy still ran on changed files in those directories, but it had to guess their flags and had no include paths, so it emitted bogusclang-diagnostic-errorannotations such as'server.hpp' file not foundand'nlohmann/json.hpp' file not found(see #632).DynamoDB and OTel stay off because they fetch large dependencies (aws-sdk-cpp) at configure time.
Verification (local, using #632's head, Boost 1.81, clang-tidy-15):
compile_commands.json. clang-tidy reproduces the "file not found" errors onmain.cpp,client_entity.hppanddata_model.hpp.redis_source.cpp, produce no include errors.This PR only changes the workflow.
files-changed-onlymeans the lint job on this PR won't exercise any C++ files, so the improvement will first show up on the next PR that touchescontract-tests/or the Redis source.Link to Devin session: https://app.devin.ai/sessions/4021a66d4d124922bd394b8a65ca637d
Open in Devin Desktop: https://app.devin.ai/desktop/session/4021a66d4d124922bd394b8a65ca637d?variant=devin
Requested by: @kinyoklion
SDK-3355