fix(im): make reaction scope conditional - #2353
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughMessage-pull shortcuts now declare ChangesMessage reaction scope handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change makes reaction permissions conditional for message-pulling shortcuts while preserving the default enrichment behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Make the reaction scope conditional for message-pulling shortcuts so
--no-reactionscan fetch messages without requiringim:message.reactions:read. The default enrichment path still preflights the reaction scope before sending a request.Changes
im:message.reactions:readfrom unconditional scopes toConditionalScopesfor the four message-pulling shortcuts.Test Plan
make unit-test)lark-cli im +chat-messages-listflowmake buildmake vetmake fmt-checknode scripts/skill-format-check/index.jsRelated Issues
Summary by CodeRabbit
Bug Fixes
--no-reactionsskip both reaction loading and permission checks.Documentation