Set up strict linting by bezbac · Pull Request #32 · langfuse/opencode-observability-plugin

bezbac · 2026-08-20T10:16:42Z

Summary

enable core ESLint recommended rules and the requested strict type-aware rules
restrict unambiguous truthiness coercion through Boolean(...), while allowing legitimate String(...) and Number(...) conversions
restrict negated inequality comparisons in favor of direct inverse operators
keep rule enablement isolated and fix each occurrence in its own atomic commit
leave no ESLint disable directives in the final tree
add strict Knip checks in a standalone commit and keep CI enforcement last

Verification

pnpm run format
pnpm run build
pnpm run lint
pnpm run knip
pnpm run test:integration (16 tests passed)

Linear Issue: LFE-15365

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Setup eslint

75bd090

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

cursor Bot force-pushed the cursor/setup-plugin-linting-33bc branch from b59dc98 to 5592947 Compare August 20, 2026 10:39

cursoragent and others added 28 commits August 20, 2026 10:47

Setup strict TypeScript eslint presets

6722991

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (1)

b212973

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (2)

ed55272

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (3)

832d0d0

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (4)

9b87b62

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (5)

9168179

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (6)

96ca395

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (7)

0655d82

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/index.ts (8)

604c720

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (1)

0bf5aa1

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (2)

ac6a99d

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (3)

10a83c5

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (4)

2e69922

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (5)

818b520

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (6)

baab056

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (7)

5c05ca9

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (8)

d9d2a92

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (9)

83087f5

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/langfuse.ts (10)

4b3d1b7

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in src/utils.ts (1)

917558d

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (1)

a0d381a

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (2)

92efd06

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (3)

1054c07

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (4)

f81397b

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (5)

d4b3a10

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (6)

19bee36

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (7)

7c2cf8b

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fix lint violation in test/integration/plugin.test.ts (8)

0e948e5

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

cursoragent and others added 7 commits August 20, 2026 11:27

Fail explicitly for a missing first generation

c5a3655

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Fail explicitly for a missing second generation

e31f3b7

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Validate retried generation output with Effect Schema

f9e6ff1

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Validate discovered tools with Effect Schema

72a1eda

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Format the unavailable collector port explicitly

17b2fde

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Handle unavailable collector close results explicitly

fc32c63

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Restore resource environment variables reflectively

209cb66

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

cursor Bot force-pushed the cursor/setup-plugin-linting-33bc branch 2 times, most recently from 4dfe7f8 to 494870f Compare August 20, 2026 11:43

cursoragent and others added 17 commits August 20, 2026 11:49

Restrict implicit-looking coercion syntax

2913624

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check active tool session presence explicitly

ec85fea

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check active generation session absence directly

361522a

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check message generation session absence directly

31fc85f

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check turn observation session absence directly

a15950b

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check latest turn session absence directly

baec1ff

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check reasoning message absence directly

52934c2

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check existing generation message absence directly

5165a0e

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check new generation message absence directly

4095758

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check active generation message absence directly

eac6fdb

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check failed generation message absence directly

94c5689

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check parent session absence directly

ec2234c

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check assistant text content explicitly

42fe288

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check assistant reasoning content explicitly

5da855e

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Check source message absence directly

849a28f

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Setup knip

2a2fba7

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

Run linting checks once per change

47fd32c

Co-authored-by: Ben Bachem <bezbac@users.noreply.github.com>

cursor Bot force-pushed the cursor/setup-plugin-linting-33bc branch from 494870f to 47fd32c Compare August 20, 2026 11:50

bezbac changed the title ~~chore: set up strict linting for opencode plugin~~ Set up strict linting Aug 20, 2026

bezbac marked this pull request as ready for review August 20, 2026 11:53

bezbac merged commit 3412306 into main Aug 20, 2026
4 checks passed

Navigation Menu

Set up strict linting - #32

Set up strict linting#32
bezbac merged 187 commits into
mainfrom
cursor/setup-plugin-linting-33bc

bezbac commented Aug 20, 2026 •

edited by cursor Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bezbac commented Aug 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bezbac commented Aug 20, 2026 •

edited by cursor Bot

Loading