feat(api): update API spec from langfuse/langfuse cdc9c1d - #1885
langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Looks good, this is a mechanical Fern-generated API client update.
What was reviewed: the removal of the unused SdkLogBody/SdkLogEvent ingestion types (confirmed no remaining references anywhere in the repo), the new optional deprecation/object_start_time/start_time fields and their serialization, and the added sunset/deprecation docstrings. Checked a docstring claim that Python/JS SDKs already send the x-langfuse-ingestion-version: 4 header — the claim is inaccurate for the Python SDK's default exporter but it's prose-only in generated code, not a functional bug.
Extended reasoning...
Overview
This PR touches only the auto-generated Fern API client under langfuse/api/. It removes the deprecated sdk-log ingestion event type, adds several new optional fields (deprecation on IngestionResponse, object_start_time on comment creation, start_time on the legacy observations v1 get endpoint), and adds/updates docstrings describing deprecation timelines and real-time read-path guidance. No hand-written SDK logic, tests, or docs are modified.
Security risks
None identified. The changes are additive optional query/body parameters and docstring text; no auth, crypto, or permission logic is touched.
Level of scrutiny
Low-to-moderate is appropriate: this is generated code mirroring an upstream OpenAPI/Fern spec change, and the removed type (SdkLogBody/SdkLogEvent) has no other references in the repository, so its removal is not a breaking change for this codebase. The bug hunting system reported no findings, and my own check confirmed the removed symbols are unused elsewhere in the repo.
Other factors
The one item worth noting (but not blocking) is that the new OpenTelemetry client docstring asserts current Python/JS SDKs already send x-langfuse-ingestion-version: 4, which doesn't match the default OTLP exporter behavior in this SDK — this is a documentation nuance in generated prose, not a code defect, so it doesn't warrant blocking approval.
The PR should not merge until compatibility is preserved for the removed public SDK-log symbols through the newly documented deprecation window.
Summary
This generated API-spec update adds optional object start-time lookup hints, exposes ingestion deprecation metadata, expands v3 sunset guidance, and removes the SDK-log ingestion models.
objectStartTimesupport to comment creation.startTimeto legacy single-observation retrieval.Reviews (1) · Last reviewed commit: "feat(api): update API spec from langfuse..."