Skip to content

feat(api): update API spec from langfuse/langfuse 5a31664 - #1884

Closed
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-5a31664-35092801147-1
Closed

langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-5a31664-35092801147-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

RetriggerConfidence Score: 4/5

The PR should not merge until compatibility is preserved for the removed public SDK-log imports.

Summary

This PR regenerates the API client against the updated upstream specification.

  • Adds optional start-time hints to comment creation and legacy observation lookup.
  • Exposes ingestion deprecation metadata and expands the v3 ingestion sunset guidance.
  • Removes SDK-log event models and exports; the abrupt public-import break requires compatibility handling.

Reviews (1) · Last reviewed commit: "feat(api): update API spec from langfuse..."

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — mechanical, auto-generated Fern API client update. Checked that the new object_start_time (Comments API) and start_time (legacy Observations V1) parameters are correctly threaded into the JSON body / query params respectively, and confirmed SdkLogEvent/SdkLogBody removal has no remaining references anywhere else in the repo.

Extended reasoning...

Overview

This PR is entirely auto-generated Fern API client code under langfuse/api/, syncing the Python SDK with an upstream OpenAPI spec change (commit 5a31664 in langfuse/langfuse). It adds two new optional performance-hint parameters (object_start_time to Comments create, start_time to legacy Observations V1 get), removes the SdkLogEvent/SdkLogBody type from the public API surface and the IngestionEvent discriminated union, and rewrites deprecation docstrings for the legacy v3 ingestion endpoints to reflect a November 16, 2026 shutdown date.

Security risks

None identified. No auth, crypto, or permission logic is touched. The new parameters are plain optional datetime hints passed through to query/body params using the existing serialization helpers (serialize_datetime, jsonable_encoder), consistent with existing patterns in the file.

Level of scrutiny

Low-to-moderate is appropriate: this is generated client code mirroring a spec change, not hand-written business logic. I verified the two functionally interesting pieces by hand: (1) that object_start_time is correctly added to the request body dict in comments/raw_client.py for both sync and async clients, and (2) that start_time is correctly serialized into the params dict for the legacy observations GET request in legacy/observations_v1/raw_client.py, again for both sync and async variants. Both are correct and follow the existing conventions of the surrounding generated code.

Other factors

I searched the full repository for any remaining references to SdkLogEvent, SdkLogBody, or sdk_log and found none outside the diff itself, confirming the removal does not break any other code in the SDK. The bug hunter reported no findings and exited via dry_streak, and my own targeted check of the two new parameters and the removed type confirms correctness. Given the generated, low-risk nature of the change and the absence of any breakage, this is safe to approve without further human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant