Skip to content

feat(api): update API spec from langfuse/langfuse c974e07 - #1873

Open
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-c974e07-34443975179-1
Open

feat(api): update API spec from langfuse/langfuse c974e07#1873
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-c974e07-34443975179-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

Summary

  • Adds objectStartTime support to synchronous and asynchronous comment clients.
  • Adds startTime query support to legacy observation retrieval.
  • Parses optional _deprecation metadata from ingestion responses.
  • Updates ingestion endpoint deprecation messages and documentation.

Reviews (1) · Last reviewed commit: "feat(api): update API spec from langfuse..."

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — straightforward, mechanical changes to Fern auto-generated API client files.

What was reviewed: the new optional object_start_time/start_time params added to the comments-create and legacy observations-get clients (verified they're passed through as simple optional query/body fields with no behavior change when omitted); the new deprecation field added to IngestionResponse (standard optional aliased field, follows existing pattern); and the reworded deprecation docstring/warning text on the legacy ingestion batch endpoint (text-only change, no logic touched).

Extended reasoning...

Overview

All 8 changed files are auto-generated Fern API client files under langfuse/api/. The diff adds: (1) an optional object_start_time parameter to the comments create endpoint (client.py, raw_client.py, create_comment_request.py) wired through as a simple optional field passed to the request body; (2) an optional start_time parameter to the legacy observations_v1 get endpoint, serialized via the existing serialize_datetime helper and passed as a query param only when not None; (3) a new optional deprecation/_deprecation field on IngestionResponse, following the exact same aliasing pattern used elsewhere in the codebase (e.g., FieldMetadata(alias=...)); and (4) a text-only rewrite of the deprecation warning/docstring on the legacy ingestion batch endpoint, softening language about the endpoint's removal timeline.

Security risks

None identified. No authentication, authorization, cryptography, or data-handling logic is touched. The new parameters are optional, default to None/OMIT, and are conditionally included in the request only when provided (using the standard serialize_datetime and OMIT conventions already used throughout the generated client). The new response field is purely additive and optional, so it cannot break existing deserialization. The docstring/deprecation text changes have no runtime effect.

Level of scrutiny

This warrants only a light review. The files are all marked "auto-generated by Fern from our API Definition," the changes are small, additive, and follow pre-existing patterns exactly (same style as other optional datetime/query params elsewhere in the client), and there is no custom business logic, control flow, or security-sensitive code involved.

Other factors

No CLAUDE.md conventions apply. The bug-hunting system reported no findings, and my own reading of the full diff (all three chunks) confirms it is consistent with the PR description — no discrepancies between claimed and actual changes. There is no outstanding reviewer objection in the PR timeline to weigh against approval.

@niklassemmler

Copy link
Copy Markdown

@maxdeichmann FYI the start_time changes here are part of my work and are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants