Repository navigation
test: unified-start test kit hooks and ten start planted bugs (stacked on #291) - #293
Draft
unbalancedparentheses wants to merge 5 commits into
Draft
unbalancedparentheses wants to merge 5 commits into
unbalancedparentheses wants to merge 5 commits into
Conversation
unbalancedparentheses
force-pushed
the
test/unified-start-kit-planted
branch
3 times, most recently
from
November 18, 2026 01:08
bd74962 to
5862b81
Compare
Contributor
Author
|
Planted-bug matrix, patches 25–34 (fede, head Layers: T = tests with failpoints (real Tokio), S = simulated suites, V = TLA+ trace validation. The baseline control was missed by all three layers, as it should be.
Every start bug is now caught by at least 2 layers. New
Two patches were replaced:
|
unbalancedparentheses
force-pushed
the
test/unified-start-kit-planted
branch
from
November 21, 2026 16:26
5862b81 to
40d5f47
Compare
…records start traces
…atches; regenerate patches 28 and 32
…nd 28 replaced start_races.rs pins each interleaving with gates or a failpoint (start.init_timer_fire), run on real Tokio and, as sim_tests, under the simulator: the init timer reaching the cell after a ready commit (25), a kill outranking a held signal (33), start_link through a parent already exiting in its own turn (32), a ready return after the group's admission closed during shutdown (34). Replaced: 28 (answer the requested reason) was an equivalent mutant, since a non-ready decision freezes the reason, so requested and final never differ; now a failed start answered before the child's publication, caught by a multi-thread slow-drop test and a new start trace. 27 (deliver a Normal failed-start notice to a waiting non-trapping parent) has no behavioural effect (the parent cannot change its trap flag while it waits, and an untrapped Normal signal is ignored), so only trace validation saw it; now a failed start_monitor's Down delivered instead of consumed.
unbalancedparentheses
force-pushed
the
test/unified-start-kit-planted
branch
from
November 21, 2026 17:01
40d5f47 to
2b983ed
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #291 (unified start). Two pieces of the unified-start scope that #291 leaves out:
Test kit (design section 10):
Mock::on_started(|ctx| Init::...)sets what the mock'sstarted()returns.start_delay(d)makes a slow initialiser (virtual time under the simulator in tasks mode).drop_flag(flag)setsflagwhen the mock's state is dropped, so a test can check that a failed start answered only after publication. These work in both modes. Tests:mock_on_started_error_answers_after_dropandmock_start_delay_hits_init_timeout(testing/tests/tasks_kit.rs).Ten unified-start planted bugs (design 16.5),
verification/planted/patches/25-34, listed inINDEX.tsv:Normalfailed-start notice is delivered;The runner's V layer now also records the
lifecycle_traceandstart_tracetraces. CI'sgit apply --checkcovers the new patches.Runner results (layers T, S, V and a baseline control, on fede) will be posted as a comment.
Model: no change because this PR only adds test-kit hooks (testing crate) and planted-bug patches; no modelled code changes.