Strip docx underline spans and flag the minus signs OCR reads from separator lines - #34
Merged
Merged
Conversation
…ads from separator lines (t42)
…ads from separator lines (t42)
…ads from separator lines (t42)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every ticket writes its tests before its code, and its pull request reports a run over a target set or a corpus folder with the number of flagged fields. See docs/plan.md.
First, pandoc writes an underlined run in a docx file as
[text]{.underline}, which LambdaFeedback does not render. The tool converts docx files with pandoc's
bracketed_spansextension switched off, so the text is written without the brackets. Second, when Mathpix
reads a PDF that Lambda Feedback printed, it reads the horizontal separator lines as minus
signs at the start or end of the neighbouring maths. The tool flags a display maths that
begins or ends with a lone minus sign. The ticket is done when the MECH docx sheets carry no
bracketed span and the ME2 solutions report the fields with a stray minus sign.
Workbench ticket t42.