Count an ignored image against a spec try and report the drop - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t24 (report each image a spec marked ignore, rewrite the spec once with that finding, and say on the coverage line how many images a set dropped) was built against the old spec loop and could not be merged after t28 replaced that loop with
spec.iterate_spec. Do it again on the current main, inside the loop:package.ignored_images(draft)as t24 wrote it: one finding per ignored block whose lines hold![, messageb10 (lines 29-30) holds an image and is marked ignore.(keep t24's tests in tests/test_package.py).iterate_spec, after each try's spec run, count those findings into the try's score beside the unassigned blocks and errors, and show them to the next call in the revision prompt as coverage findings, so a spec that ignores a figure is revised like one that leaves a block unassigned.coveragestage line of the chosen try names the images still dropped:...; 2 images dropped: b10 (lines 29-30), b14 (lines 41-42), and the run continues.ignore(t24's wording).coverageline's dropped-images form, and the try score's third term.Tests: tests/test_spec.py runs a source with a figure paragraph through a fake backend whose tries all ignore it and asserts the score, the revision prompt and the coverage line. Done when
in2lambda-agent runover a sheet whose spec ignores a figure revises the spec and reports the drop.Workbench ticket t32.