Finish the gate: keep private specs and baselines out of the repository - #28
Merged
Merged
Conversation
…he repository (t31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t21 (the gate command, CI workflow and baselines) reached its cost cap before applying the four changes its review asked for. Its work is on this branch; this ticket makes those four changes and nothing more:
git rm --cachedboth, addcorpus-specs/to .gitignore, and have the workbench check read the private baseline fromcorpus-specs/gate-baseline.json. The ci-corpus specs are synthetic: move them toci-corpus/specs/<folder>/in2lambda-spec.yamland point ci-baseline.json'sspecsthere.gh pr mergeas soon as its own check passes and cannot wait for a GitHub check, so a required check blocks every merge. The workflow stays as CI's report.--cachedefaults differ betweencorpus(./.in2lambda-agent) andgate(~/.cache/in2lambda-agent); say each once where its command is described, and say why.in2lambda-agent corpus --helpshows--cache, and tests/test_cli.py covers it.Full suite green, then offer the work.
Workbench ticket t31.