Finish the spec iteration: stream its lines and document the set stage - #23
Merged
Merged
Conversation
…he set stage (t28)
…he set stage (t28)
…he set stage (t28)
…he set stage (t28)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t16 (spec iteration against coverage, with a second document of the set as the check) reached its cost cap with its reviewer's last two changes open. The work is on its branch; this ticket finishes it and nothing more:
iterate_specin in2lambda_agent/pipeline.py accumulates its stage lines andrunreplays them after the loop returns, so the page (ui/server.py streamson_stage) showsocrand then nothing through three model calls and six spec runs, then eleven lines at once. Giveiterate_specthe callback (result.add_stageor anon_stageparameter) and report each line as it is made; a test in tests/test_pipeline.py asserts the order in whichon_stagesees them.add_stagecalls with a string constant only, so thesetstage added with a variable is invisible to it, andsetappears in docs/how-it-works.md as a corpus column anyway. Make the guard see the stagesiterate_specemits and match a stage's own section, not any backticked word; then correct the page: ten stage names not nine, asetrow in the table, and the model-call section says what the spec iteration's calls are given (the coverage of each try, and the second document's) and how many there may be (--tries).Full suite green, README's run section names
--tries. Done when the page streams every line as it happens and the docs test fails if a stage is undocumented.Workbench ticket t28.