Fix for mismatched brackets#265
Open
m-messer wants to merge 1 commit into
Open
Conversation
…cket_notation` for better handling of mismatched brackets
peterbjohnson
approved these changes
Jul 23, 2026
peterbjohnson
left a comment
peterbjohnson
left a comment
Member
There was a problem hiding this comment.
In principle this looks good, including the custom feedback.
I suggest try it out in the app after deployment to double check UX.
I haven't checked the detail of the code is it's quite dispersed through the function so harder to check - I don't want to add delays.
Member
Author
|
Thanks, it is currently deployed on the LF staging instance if you want to try it before merging. Otherwise, I'll merge on Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the change in #263, students could enter mismatched brackets
[x+y), and it would be translated to(x+y).This fix requires students to have matched brackets
[x+y]for it to pass the preview step. A tag was added to the feedback.