variants/linux: adapt to upstream API changes, bump ardulinux to v0.2.3 - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing onto dev picks up three upstream changes the linux target has to answer:
setRxBoostedGainMode()changed return typevoid->bool. MirrorCustomSX1262Wrapperand map the RadioLib status throughRADIOLIB_ERR_NONE. Also fixes the "void value not ignored" error atMyMesh::setRxBoostedGain().attachDynamicPrefs(KeyValueStore*)was added to the board interface.LinuxBoardgets the same no-op asESP32Board/NRF52Board/STM32Board; the linux target keeps its runtime config inmeshcored.ini. Needs an explicit<helpers/KeyValueStore.h>, as the other boards do.src/helpers/ethernet/is new and needsRAK13800_W5100S.h/WiFi.h. Excluded from the linux build, consistent with -<mesh/eth/>.ardulinux v0.2.3 line-buffers stdout and makes
Serial.flush()real, so meshcored's logs reach journald as they happen rather than at exit, under a service manager the previous behaviour lost them entirely if the process was killed.