fix: chat widget is black again - #259
Closed
juliankepka wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Unfortunately this wasn't a good solution. I should have informed myself better about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a pretty fix. The widget renders into a closed shadow root, so no stylesheet from the host
page can reach inside. I tried
globals.csswith!importantand it stays white. Custom propertiesdo inherit through the boundary, but the bubble icon isn't themed through one: the widget hardcodes
.c7-bubble svg { stroke: white; }.So the only option on our side is patching
attachShadowto force the root open and inject anoverride (the
async→deferswitch makes sure our patch runs first).Proper fix belongs upstream: that
stroke: whiteshould be black, or driven by a custom property soit can be themed from outside. Happy to drop this workaround once that exists.