Skip to content

Cache the joined log buffer and skip it for single-line rules - #1329

Open
DigitalVeer wants to merge 1 commit into
kubernetes:masterfrom
DigitalVeer:lastline-match
Open

Cache the joined log buffer and skip it for single-line rules#1329
DigitalVeer wants to merge 1 commit into
kubernetes:masterfrom
DigitalVeer:lastline-match

Conversation

@DigitalVeer

Copy link
Copy Markdown
Contributor

This PR makes two changes on top of #1323:

  1. The buffer caches the joined string. Push clears the cache.
  2. CompilePattern marks the rules that can match only one line. Match tests these rules against the last line only.

This will help NPD act more reliably during log floods.

Benchmark

BenchmarkPushAndMatchAll (linux/arm64, Go 1.26):

Time per line Memory per line Allocations per line
Before, buffer size 10 18484 ns 9221 B 26
After, buffer size 10 1659 ns 0 B 0
Before, buffer size 100 174067 ns 99118 B 28
After, buffer size 100 1687 ns 0 B 0

API change

  • CompilePattern returns *Pattern instead of *regexp.Regexp.
  • This removes String() from the LogBuffer interface as it is not used anymore.

The log buffer joins every buffered line and scans all of them for
each pattern on every push, which is wasted work when a pattern
cannot even match across lines. The buffer now caches the joined
string, and Push invalidates the cache. CompilePattern marks the
patterns that cannot match across lines (no start anchor, no way to
match a newline, and the appended \z anchor binds every branch) and
Match checks them against the most recent line alone.
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DigitalVeer
Once this PR has been reviewed and has the lgtm label, please assign random-liu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @DigitalVeer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant