Skip to content

Set the Node UID on recorded events - #1325

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
DigitalVeer:node-event-uid
Jul 25, 2026
Merged

Set the Node UID on recorded events#1325
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
DigitalVeer:node-event-uid

Conversation

@DigitalVeer

Copy link
Copy Markdown
Contributor

Recorded events refer to the node with an ObjectReference that has no UID. The client already reads the Node object at startup to check that kube-apiserver is ready, and this PR stores the UID from that read. The node status patch returns the Node object, so the client stores that UID too. This also removes a pending TODO in problem_client.go.

Fixes #1324

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @DigitalVeer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from klueska and mrunalp July 23, 2026 23:04
@DigitalVeer
DigitalVeer force-pushed the node-event-uid branch 2 times, most recently from 6efc16e to 3140d8b Compare July 24, 2026 05:42
Recorded events refer to the node with an ObjectReference that has no
UID. The client already reads the Node object at startup to check that
kube-apiserver is ready, and this change stores the UID from that read.
The node status patch returns the Node object, so the client stores
that UID too.

This change removes the TODO in problem_client.go.
@hakman

hakman commented Jul 25, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2026
@hakman

hakman commented Jul 25, 2026

Copy link
Copy Markdown
Member

Thanks for fixing this @DigitalVeer
/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DigitalVeer, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 9a162b1 into kubernetes:master Jul 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node events are missing from 'kubectl describe node' because involvedObject.uid is not set

2 participants