Set the Node UID on recorded events - #1325
Conversation
|
Hi @DigitalVeer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6efc16e to
3140d8b
Compare
Recorded events refer to the node with an ObjectReference that has no UID. The client already reads the Node object at startup to check that kube-apiserver is ready, and this change stores the UID from that read. The node status patch returns the Node object, so the client stores that UID too. This change removes the TODO in problem_client.go.
3140d8b to
c1d461f
Compare
|
/ok-to-test |
|
Thanks for fixing this @DigitalVeer |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DigitalVeer, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Recorded events refer to the node with an
ObjectReferencethat has no UID. The client already reads the Node object at startup to check that kube-apiserver is ready, and this PR stores the UID from that read. The node status patch returns the Node object, so the client stores that UID too. This also removes a pending TODO inproblem_client.go.Fixes #1324