feat: add Controller Internals Grafana dashboard - #460
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rawadhossain The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @AvineshTripathi |
AvineshTripathi
left a comment
There was a problem hiding this comment.
initial look! I will need some time here to understand. Too many variables here!
| "type": "prometheus", | ||
| "uid": "${datasource}" | ||
| }, | ||
| "expr": "min(up{job=\"nrr-metrics-service\"})", |
There was a problem hiding this comment.
There can be a different name for the job for e.g. https://github.com/kubernetes-sigs/node-readiness-controller/blob/main/charts/node-readiness-controller/templates/servicemetrics.yaml#L5 which might break this
There was a problem hiding this comment.
my bad, that was for my local testing. Forgot to change it.
Fixed it. Should be fine now.
There was a problem hiding this comment.
we would need a text box for this or dropdown to select job?
Signed-off-by: Rawad Hossain <rawad.hossain00@gmail.com>
ae4a67c to
9dcb599
Compare
|
Hey @AvineshTripathi, here's a quick breakdown so its easier to skim. so overall, it's just: one query per panel, wrapped in a bit of formatting (colors, units, layout) that repeats the same way across all of them. |
AvineshTripathi
left a comment
There was a problem hiding this comment.
am not an expert in this but it LGTM
Description
This PR adds the Controller Internals section, fifth of five planned dashboard sections for node-readiness-controller.
Questions it answers:
Most of these panels use metrics from controller-runtime and kube-state-metrics.
Panels in this Section
Screenshot
Video demo
Section.5.mp4
Related to Issue #459
Type of Change
/kind feature
Testing