Skip to content

Milvus: document GPU and SR-IOV networking support - #1061

Open
tamalsaha wants to merge 2 commits into
milvus-etcdfrom
milvus-gpu-sriov
Open

tamalsaha wants to merge 2 commits into
milvus-etcdfrom
milvus-gpu-sriov

Conversation

@tamalsaha

@tamalsaha tamalsaha commented Sep 10, 2026

Copy link
Copy Markdown
Member

What

Documents the user-facing surface of pl2/milvus-fixes/sriov-gpu-design.md: spec.gpu (Standalone top-level and per Distributed role) and spec.network.sriov (per Distributed role, with a Standalone-scoped subset), including the follow-ups added after the initial kubedb/apimachinery#1898/kubedb/milvus#69 pass.

  • concepts/milvus.md: adds spec.gpu/spec.network field reference sections, including the optional network.sriov.gds second attachment and spec.topology.distributed.<role>.groups (heterogeneous GPU pools, with per-group storageType/storage for streamingnode).
  • guides/milvus/gpu-sriov/: guide covering the MilvusVersion GPU capability gate, why the SR-IOV advertise-IP init container is Distributed-only (now documenting both the user.yaml file overlay and the MILVUS_CONF_<SECTION>_IP env-var mechanism it runs belt-and-braces), the topology-coupling requirement, GPU Direct Storage via network.sriov.gds, groups (including scoping a MilvusOpsRequest to a single group), the Milvus.status.conditions[SRIOVNetworkAttached] condition, a full worked example, and known limitations — carried over honestly from the design doc rather than overclaiming validation this hasn't had.

Depends on

Stacked on milvus-etcd (#1060). Companion to kubedb/apimachinery#1898 and kubedb/milvus#69.

Testing

No live-cluster verification — this guide is drafted from the CRD schema and the design doc, consistent with how the rest of this branch's docs were produced (per #1060's own testing note).

Documents pl2/milvus-fixes/sriov-gpu-design.md's user-facing surface:
spec.gpu (Standalone top-level and per Distributed role) and
spec.network.sriov (per Distributed role, with a Standalone-scoped subset).

- concepts/milvus.md: adds a spec.gpu and spec.network field reference
  section, alongside the existing spec.podTemplate section.
- guides/milvus/gpu-sriov/: new guide covering the MilvusVersion GPU
  capability gate, why the SR-IOV advertise-IP init container is
  Distributed-only, the topology-coupling requirement (all five roles, not
  just the GPU-bearing ones), a full worked example, and known
  limitations -- carried over honestly from the design doc rather than
  overclaiming validation this hasn't had yet.

Companion to kubedb/apimachinery#1898 and kubedb/milvus#69.

Signed-off-by: Tamal Saha <tamal@appscode.com>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1181a32d-e228-43fc-b9e5-0cabc06f2435

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit f37583c):

https://kubedb-v2-hugo--pr1061-milvus-gpu-sriov-jiljn0by.web.app

(expires Tue, 22 Sep 2026 16:57:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943

…ition

The GPU/SR-IOV guide and Milvus CRD field reference predated all four
follow-ups closed in kubedb/apimachinery#1898 and kubedb/milvus#69 after
the initial pass: the env-var (MILVUS_CONF_<SECTION>_IP) advertise-IP
mechanism, the optional GDS second SR-IOV attachment, heterogeneous GPU
pools (spec.topology.distributed.<role>.groups) including per-group
OpsRequest scaling and per-group StreamingNode storage, and the new
Milvus.status.conditions[SRIOVNetworkAttached] observability condition.

Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant