Remove boxed null guards from generated logarithmic conversions - #227
Merged
matt-edmondson merged 2 commits intoSep 13, 2026
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix null check for value type parameters in logarithmic conversions
Remove boxed null guards from generated logarithmic conversions
Sep 13, 2026
matt-edmondson
marked this pull request as ready for review
September 13, 2026 13:04
|
matt-edmondson
deleted the
copilot/fix-logarithmic-conversions-null-check
branch
September 13, 2026 23:28
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



LogarithmicScalesGeneratorwas still emittingArgumentNullException.ThrowIfNull(linear)for linear inputs that are nowreadonly record structquantities. That null check is unreachable and forces boxing on every conversion call in the generated logarithmic APIs.Generator emission
LogarithmicScalesGeneratorforFrom*logarithmic conversion methods.Regenerated logarithmic outputs
From*conversion no longer includes the boxed null check:Cents,Decibels(bothFromGainandFromPowerRatio),DirectionalityIndex,PH,Semitones,SoundIntensityLevel,SoundPowerLevel,SoundPressureLevel.Allocation regression guard
QuantityValueTypeTeststo assert zero allocation for a logarithmic conversion path (Decibels.FromGain), closing the coverage gap that allowed this drift.