Address the SonarCloud findings from #219

[matt-edmondson]

Follow-up to #219, which merged before these landed. The quality gate passed there, so nothing blocked the merge — but six new issues were reported without being named, and all six are in code that PR added.

Its dashboard is reachable from the agent sandbox, so these came from the API rather than from guessing.

Four MSTest findings, and why the count mattered

MSTEST0046 wanted Assert.Contains over StringAssert.Contains, and MSTEST0037 wanted Assert.DoesNotContain over Assert.IsFalse(… .Any(…)).

This repository wants exactly that. Semantics.Test has 105 Assert.Contains call sites and had two StringAssert.Contains — both from #219 — plus 10 existing Assert.DoesNotContain. So the new test was the outlier, and these changes move it onto the surrounding convention.

Worth recording why that was checked rather than assumed: the identical rule went the other way in ktsu.Coder earlier today, where StringAssert.Contains has 188 call sites and the bare form has none, so the right answer there was to decline it. Same rule, opposite conclusion, decided by counting.

DoesNotContain takes an expected value and a collection rather than a collection and a predicate, so both assertions now project the refusals to their kinds first — which reads more directly than the IsFalse-around-Any it replaces:

VocabularyIssueKind[] kinds = [.. Vocabulary().Refused.Select(issue => issue.Kind)];

Assert.DoesNotContain(VocabularyIssueKind.UnknownDimension, kinds, "…");

Two nested ternaries, at major severity

S3358 on QuantityVocabulary.cs. Both predate the lift and moved with the file, which is why Sonar counts them as new code — and both are worth extracting on their own merits, since each was a physics rule compressed into nesting.

They are now named methods with the reasoning written out: BoundOf (only the magnitude form is bounded below at all, so a stricter floor on an overload applies there and nowhere else) and Wanted (a cross product defaults to three components because that is where a cross product exists; everything else defaults to every form).

Verification

• dotnet build and dotnet build -c Release — clean, 0 warnings
• Semantics.Test: 1136 tests, 0 failed
• Semantics.Cpp.Test: 27 passed, including the g++/clang++ compile tests
• Generated output still byte-identical — no drift under Semantics.Quantities/Generated/
• No suppressions added

🤖 Generated with Claude Code

https://claude.ai/code/session_01QGCMUrT3jBgmANHNHcPmBf

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud