Skip to content

Many bug fixes - #61

Merged
nil-malh merged 38 commits into
mainfrom
feat/bug-fixes
Oct 6, 2026
Merged

nil-malh merged 38 commits into
mainfrom
feat/bug-fixes

Conversation

@nil-malh

@nil-malh nil-malh commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

📝 Description

Resolves #


🔄 Type of Change

  • 🐛 Bug fix — non-breaking change that fixes an issue
  • ✨ New feature — non-breaking change that adds functionality
  • 💥 Breaking change — fix or feature that changes existing behaviour
  • ♻️ Refactoring / technical debt — no functional change
  • 📖 Documentation — doc-only changes
  • ⬆️ Dependency update — bumped library/plugin version(s)
  • 🔧 CI / build — changes to workflows, pom.xml, tooling

✅ Pre-Merge Checklist

Code Quality

  • My code follows the Palantir Java Format style (passes mvn spotless:check)
  • I have added or updated Javadoc on public types and methods

Tests

  • I have added unit tests that cover the new / changed behaviour
  • All existing and new tests pass locally (mvn verify)
  • JaCoCo line coverage ≥ 70 % is maintained
  • Tests using Testcontainers are isolated and do not leave containers running

Licensing

  • Apache 2.0 license header has been added to every new source file (using spotless)

🧪 How to Test Locally

# 1. Build and run all tests (requires Docker for Testcontainers)
mvn verify

# 2. Check code style
mvn spotless:check

📸 Screenshots / Logs


📚 Additional Context

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

📋 Unreleased Changelog Preview

This is what the next release notes will look like based on commits in this PR.

Changelog

All notable changes to this project will be documented in this file.

[Unreleased]

♻️ Refactoring

  • Enhance plugin loading and shutdown logic

  • Enhance timeout handling and improve documentation in KafkaRecordFetcher

  • Extract null value message to constant in MatchResult

✨ Features

  • Add AvroJson and AvroLogicalTypesSerializationTest for JSON conversion of Avro logical types

  • Enhance DynamicVariableFactory for thread-safety and case-insensitivity

  • Added two new MatchResult noRecords and nullValue

  • Introduce FetchTimeoutException for clearer timeout handling

⬆️ Dependency Updates

  • Bump ktestify-parent version from 1.0.4 to 1.0.5

🐛 Bug Fixes

  • Fixed an issue where a NullPointerException was thrown on unset environment variables

  • Close URLClassLoader in PluginRegistry to prevent file handle leak

  • Add missing schemas directory default to reference.conf

  • Harden XML parsers against XXE attacks in XMLUtils

  • Enforce error taxonomy and add missing exception constructors

  • Correct over-suppression of CHILD_NODELIST_LENGTH in XMLUtils

  • Fixed an issue where a SchemaRegistryClient was instantiated at each call instead of being cached

  • Improve byte buffer handling in AvroDeserializer

  • Include cause in ConsumerException for better error handling

  • Handle null values in record matchers and improve logging

  • Enhance security in SAXParserFactory and improve documentation

  • Improve handling of empty records in AttributeRecordMatcher

  • Improve getLine method to handle null content and out-of-bounds indices

  • Null pointer exception on empty TimestampVariable when format is null

  • Update dependency review workflow path

🔧 Miscellaneous

  • Fixed some tests

🧪 Tests

  • Add ClasspathTestPlugin for lifecycle call assertions

  • Add TombstoneMatcherTest to verify tombstone handling across matchers

  • Rename integration tests with *ITTests

  • Rename integration tests with *ITTests


Generated by git-cliff


🔄 Run #159 · Tue, 06 Oct 2026 16:45:00 GMT

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Results

Metric Count
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0
📊 Total 0

⚠️ Coverage report not available


🔄 CI run #170 · Fri, 02 Oct 2026 21:00:26 GMT

@nil-malh nil-malh changed the title Multiple bug fixes Many bug fixes Oct 5, 2026
@nil-malh
nil-malh merged commit ac61b9d into main Oct 6, 2026
8 checks passed
nil-malh added a commit that referenced this pull request Oct 6, 2026
* fix: fixed an issue where a NullPointerException was thrown on unset environment variables

* fix: close URLClassLoader in PluginRegistry to prevent file handle leak

* fix: add missing schemas directory default to reference.conf

* fix: harden XML parsers against XXE attacks in XMLUtils

* fix: enforce error taxonomy and add missing exception constructors

* fix: correct over-suppression of CHILD_NODELIST_LENGTH in XMLUtils

* fix: fixed an issue where a SchemaRegistryClient was instantiated at each call instead of being cached

* chore: fixed some tests

* (feat/bug-fixes) style: spotless

* fix: improve byte buffer handling in AvroDeserializer

* fix: include cause in ConsumerException for better error handling

* fix: handle null values in record matchers and improve logging

* fix: enhance security in SAXParserFactory and improve documentation

* style: update comments for consistency in punctuation

* test: add ClasspathTestPlugin for lifecycle call assertions

* refactor: enhance plugin loading and shutdown logic

* fix: improve handling of empty records in AttributeRecordMatcher

* feat: add AvroJson and AvroLogicalTypesSerializationTest for JSON conversion of Avro logical types

* feat: enhance DynamicVariableFactory for thread-safety and case-insensitivity

* fix: improve getLine method to handle null content and out-of-bounds indices

* refactor: enhance timeout handling and improve documentation in KafkaRecordFetcher

* feat: added two new MatchResult noRecords and nullValue

* style: improve comments

* test: add TombstoneMatcherTest to verify tombstone handling across matchers

* refactor: extract null value message to constant in MatchResult

* style: spotless

* fix: null pointer exception on empty TimestampVariable when format is null

* ci: update CI workflow to use reusable Maven CI and add manual integration test option

* (feat/bug-fixes) style: spotless

* ci: fix workflow paths in CI and dependency review configurations

* fix: update dependency review workflow path

* style: spotless

* test: rename integration tests with *ITTests

* test: rename integration tests with *ITTests

* ci: enable integration tests by default in CI workflow

* deps: bump ktestify-parent version from 1.0.4 to 1.0.5

* feat: introduce FetchTimeoutException for clearer timeout handling

* style: spotless
# Conflicts:
#	src/main/java/io/github/ktestify/match/impl/AvroFileKeyRecordMatcher.java
#	src/main/java/io/github/ktestify/match/impl/AvroKeyRecordMatcher.java
#	src/main/java/io/github/ktestify/match/impl/FileKeyRecordMatcher.java
#	src/main/java/io/github/ktestify/match/impl/KeyRecordMatcher.java
nil-malh added a commit that referenced this pull request Oct 6, 2026
@nil-malh nil-malh mentioned this pull request Oct 6, 2026
nil-malh added a commit that referenced this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant