Add upstream push protection to go-upgrade script - #4659
Open
aravindtga wants to merge 2 commits into
Open
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a guardrail to the scripts/go-upgrade push flow to prevent accidental pushes to upstream (kptdev) repositories, with an explicit --force/-f override for intentional upstream pushes.
Changes:
- Introduce
--force/-foption parsing and logging inupgrade.sh. - Add an upstream push protection check in
lib/push.shbefore performinggit push. - Document the new option and behavior in
scripts/go-upgrade/README.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/go-upgrade/upgrade.sh | Adds FORCE flag, parses --force/-f, and logs when force mode is enabled. |
| scripts/go-upgrade/lib/push.sh | Blocks pushes when configured for upstream, unless force override is provided. |
| scripts/go-upgrade/README.md | Documents upstream push protection and --force/-f usage with examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
scripts/go-upgrade/lib/push.sh:164
- The
sedextraction for the repo name assumes the remote URL ends with.git. Iforigin_urlis configured without the suffix (common for HTTPS remotes), this will produce an invalidorigin_repoand break PR creation/logging. Make the.gitsuffix optional when extracting the repo name.
local origin_repo="${origin_owner}/$(echo "$origin_url" | sed -E 's|.*[:/][^/]+/([^/]+)\.git$|\1|')"
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
go-upgrade-upstream-push-protection
branch
from
July 23, 2026 11:31
bc2ba58 to
cd3a84e
Compare
|
aravindtga
marked this pull request as ready for review
July 23, 2026 11:36
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
July 23, 2026 11:36
dosubot
Bot
added
size:S
liamfallon
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
go-upgradepush flow that blocks pushing branches whenFORK_OWNERis set tokptdev(upstream org), preventing accidental modifications to upstream repositories.FORK_OWNER=kptdev(intentionally or accidentally), the script would push branches directly to the upstream repos. This adds a guardrail with a--force(or-f) flag to override when intentional.git pushincmd_push(), the script checks ifFORK_OWNER == "kptdev". If so, it refuses to push and records a failure unless--forceis passed.Changes
scripts/go-upgrade/lib/push.sh: Added upstream protection check beforegit pushscripts/go-upgrade/upgrade.sh: AddedFORCEoption variable,--force|-farg parsing, usage text, and startup loggingscripts/go-upgrade/README.md: Updated Options table and Fork Owner section with protection docs and examplesAI Disclosure