Repository navigation
fix(tasks): correct verifier reports and current-commit retries - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix independent Task verification failures caused by report schema rejection and incorrect session routing, and provide an explicitly confirmed retry for a changed current commit without rerunning coding.
chat,task-intake, andtask-verificationkinds rather than inferring intake fromreadOnly. Resolve restored tabs before rendering intake UI, including empty intake sessions, without sending presentation metadata to pi or widening tool permissions.task_retry_verification_current_commit(taskId, expectedRevision). Main reads the clean HEAD on the persisted Task branch; a transaction audits old/new pins, preserves historical reports, creates a fresh verifier, and reactivates the same coding Run. Attempt numbering is monotonic across commits.Safety and compatibility
Validation
pnpm check: 104 test files / 895 tests, plus 35 release tests, all passed.quick_check=ok, no foreign-key errors; all existing 22 Tasks, 33 Runs, and 5 verification records and every historical table row remained unchanged across installation and restart.task-verificationfor the historical verifier in both direct kind lookup and session history.Live recovery boundary
The affected user's Task was already marked
completedbefore installation. Live retry preflight refused to reopen it; its terminal status and original inconclusive verdict were preserved. Fresh current-commit re-verification and merged-receipt adoption were regression-tested, not executed on that completed live Task.