chore: remove v1 generator residue shipped in the wheel - #207
Open
KomanRudden wants to merge 1 commit into
Open
KomanRudden wants to merge 1 commit into
KomanRudden wants to merge 1 commit into
Conversation
Delete leftover v1 OpenAPI generator output that was being packaged into the wheel: - kinde_sdk/models/ (broken __init__ importing nonexistent modules) - kinde_sdk/test/ (generated test stubs, not collected by pytest) - kinde_sdk/docs/ (generated v1 API docs) - kinde_sdk_README.md Also drop stale references to v1-only files: - .coveragerc: omit entries for nonexistent schemas.py, model_utils.py and legacy apis/model/paths dirs - .openapi-generator-ignore (root and management) and generate_management_sdk.py custom_files: custom_exceptions.py and kinde_api_client.py (removed in 6ac3c8c / 88adfc9) - .coderabbit.yaml: path filters for v1 api/model/paths dirs - generate_management_sdk.py: fix comment claiming kinde_sdk/docs holds SDK-specific docs
Contributor
|
Important Review skippedToo many files! This PR contains 169 files, which is 69 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository: kinde-oss/kinde-python-sdk/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (169)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead output left over from the v1 OpenAPI generator. None of it is importable or collected, and part of it ships in the wheel.
kinde_sdk/docs/(90 files),kinde_sdk/test/(73 files),kinde_sdk/models/__init__.py, andkinde_sdk_README.md.import kinde_sdk.modelsalready fails onmain(ModuleNotFoundError: kinde_sdk.model).kinde_sdk.model.*/kinde_sdk.management.schemas, which don't exist, and pytest never collects them.kinde_sdk.model.user.User,kinde_sdk.apis.tags.*)..coveragercand.coderabbit.yaml.custom_exceptions.pyandkinde_api_client.py(removed earlier in6ac3c8cand88adfc9) from both.openapi-generator-ignorefiles and fromSDK_CONFIG["custom_files"]ingenerate_management_sdk.py, so regeneration doesn't re-add them.generate_management_sdk.pycomment that describedkinde_sdk/docsas the SDK's own docs.170 files changed, 1 insertion, 21,435 deletions. Not a breaking change, since nothing removed was importable.
Verification
pytest testv2: 444 passed, 3 skipped (unchanged).kinde_sdk/test/,kinde_sdk/models/orkinde_sdk/docs/.kinde_sdk,kinde_sdk.management,kinde_sdk.frontend,kinde_sdk.auth,kinde_fastapiandkinde_flaskall import.Note
Overlaps with #205 (
AGENTS.md): its line 12 (describingkinde_sdk/docs/andkinde_sdk/test/) and the second sentence of line 36 become stale once this merges.