Skip to content

feat: start new modules on the lazy web component contract - #21

Open
AndrewKirkovski wants to merge 2 commits into
mainfrom
perf/lazy-web-components
Open

AndrewKirkovski wants to merge 2 commits into
mainfrom
perf/lazy-web-components

Conversation

@AndrewKirkovski

Copy link
Copy Markdown

Problem and resulting behavior

New modules started from the old eager entry, and the template gate required preserveEntrySignatures: false, which drops the webComponent export that factory loading needs.

The template now keeps registration eager and loads its implementation through a dynamic import, with externals from a pinned Host import map snapshot. A failed or stalled load shows wippy-error and emits { message, error }. scripts/check-module.mjs enforces the new build settings and rejects a bundle that imports a package the Host does not map.

Validation

  • node scripts/check-module.mjs, npm run type-check, npm run build and the 3 UI tests pass.
  • node scripts/test-initializer.mjs passes. It skips any path under a .local folder, so it ran from a copy outside one.
  • Two independent code reviews ran on the final diff. Their finding on the failed-load path is fixed here.

Checklist

  • I followed the contribution guide and any repository-specific instructions.
  • Relevant build and lint checks pass.
  • Tests cover changed behavior. SQLite and PostgreSQL checks do not apply, because this change has no persistence or migration work.
  • UI source and regenerated tracked served assets are included together, where applicable.
  • Documentation and links describe the resulting behavior accurately.
  • No credentials, private data, or generated local runtime state are included.
  • The CLA check passes, or my GitHub account is already recorded or allowlisted.

EE2-2752. The template keeps registration eager and loads its implementation
through a dynamic import, with Host import map externals. A failed or stalled
load shows wippy-error and emits { message, error }.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant