Assignment 3 - #2
Open
kfbmartin wants to merge 22 commits into
Open
Conversation
DianaLiao
reviewed
Jul 23, 2026
| print(f"Sorry, I don't recognize that time of day. Try: morning, afternoon or evening for the time of day.") | ||
| else: | ||
| print("Sorry, I don't recognize that day. Try: Monday, Tuesday, Wednesday...") | ||
|
|
There was a problem hiding this comment.
Solid work! I think this meets the requirements fine, but as a thought exercise, think about other ways you might branch the validation so less code has to run before the user gets an error message.
Also side note, in python it's customary to name variables in snake_case instead of camelCase. so time_of_day instead of timeOfDay.
DianaLiao
reviewed
Jul 23, 2026
| elif age>=65: | ||
| #print(f"Your age is {age}.") | ||
| print("You are a Senior.") | ||
|
|
There was a problem hiding this comment.
consider adding an else statement for invalid numbers!
DianaLiao
approved these changes
Jul 23, 2026
DianaLiao
left a comment
DianaLiao
left a comment
There was a problem hiding this comment.
Looks good enough to me! I left some comments on style and refactors. Please merge any branches into main and try to keep commits for different assignments separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a pull request for all of assignment-3 work.