fix(windows): support .png format icon in tray icon - #16362
Open
mcdurdin wants to merge 2 commits into
Open
Conversation
Fixes: KEYMAN-WINDOWS-3CT Fixes: #12905
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts |
Member
Author
Contributor
Test Specs
Test Results
|
keymanapp-test-bot
Bot
removed
the
user-test-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: KEYMAN-WINDOWS-3CT
Fixes: #12905
User Testing
TEST_BASELINE: Select various keyboards and verify that the icon is shown correctly in the tray icon.
TEST_PNG_ICON: Install pngicon.kmp from pngicon.zip and verify that Keyman does not crash when selecting that keyboard (the icon will be a simplified Keyman icon).