fix(developer): tighten touch layout file structural validity checks - #16347
Open
mcdurdin wants to merge 1 commit into
Open
fix(developer): tighten touch layout file structural validity checks#16347mcdurdin wants to merge 1 commit into
mcdurdin wants to merge 1 commit into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
commented
Aug 11, 2026
Comment on lines
+275
to
+293
| // Transform the layout keys with displayMap | ||
| if(displayMap) { | ||
| Osk.remapTouchLayout(data, displayMap); | ||
| } | ||
|
|
||
| // If not debugging, then this strips out formatting for a big saving in file size | ||
| // This also normalises any values such as Pad or Width which should be strings | ||
| const writer = new TouchLayoutFileWriter({formatted: FDebug}); | ||
|
|
||
| sLayoutFile = writer.compile(data); | ||
|
|
||
| sLayoutFile = TransformSpecialKeys14(FDebug, sLayoutFile); | ||
|
|
||
| sLayoutFile = TransformSpecialKeys17(FDebug, sLayoutFile); | ||
|
|
||
| return { | ||
| output: sLayoutFile, | ||
| result | ||
| } |
Member
Author
There was a problem hiding this comment.
No changes to this code, just factored the validation out of this function to simplify test.
Fixes: #16214 Fixes: KEYMAN-DEVELOPER-39Q Test-bot: skip
mcdurdin
force-pushed
the
fix/developer/16214-tighten-touch-layout-file-validity
branch
from
August 12, 2026 05:27
e56351a to
cd674fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16214
Fixes: KEYMAN-DEVELOPER-39Q
Test-bot: skip