fix: lang query parameter overrides session lang variable - #818
Merged
mcdurdin merged 1 commit intoAug 13, 2026
Merged
Conversation
When in embedded keyboard search, if a lang parameter is passed in the query string, it should override the session value, otherwise, the first language set for a given session of Keyman Configuration will stick until the end of the session. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
approved these changes
Aug 13, 2026
mcdurdin
deleted the
fix/lang-parameter-overrides-session-value-for-lang
branch
August 13, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in embedded keyboard search, if a lang parameter is passed in the query string, it should override the session value, otherwise, the first language set for a given session of Keyman Configuration will stick until the end of the session.
Test-bot: skip