testretry: fail clearly when a retry is rejected#288
Open
bhcopeland wants to merge 1 commit into
Open
Conversation
On a non-200 the retry helper returns None, but the command logged a misleading 'No response message from retry request' warning and then returned normally, so a rejected retry (e.g. a 401) exited 0 and read as success to scripts and agents. Report the failure and abort with a non-zero exit instead; the helper already surfaces the specific API error. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a non-200 the retry helper returns None, but the command logged a misleading 'No response message from retry request' warning and then returned normally, so a rejected retry (e.g. a 401) exited 0 and read as success to scripts and agents. Report the failure and abort with a non-zero exit instead; the helper already surfaces the specific API error.