Increase pytest coverage#285
Open
aliceinwire wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arisu Tachibana <arisu.tachibana@miraclelinux.com>
bhcopeland
reviewed
Jul 24, 2026
| load_toml("missing.toml", "checkout") | ||
|
|
||
|
|
||
| def test_config_command_creates_private_example_file(tmp_path): |
Member
There was a problem hiding this comment.
I would probably isolate this to HOME. I.e. when I tested this locally I got "Config file already present", since its already there. I see you use HOME on test_load_toml_missing_required_config_aborts, so probably we should here too?
bhcopeland
reviewed
Jul 24, 2026
|
|
||
| def test_commit_find_diff_returns_latest_patch(tmp_path): | ||
| repo = subprocess.run( | ||
| ["git", "init", str(tmp_path)], check=True, capture_output=True, text=True |
Member
There was a problem hiding this comment.
subprocess.run(["git", "init", "-b", "master", str(tmp_path)], ...)
I would force master here, because later down you use master, and there is no enforcement, so its a edge case if it ever creates a repo on main instead of master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.