Conversation
Contributor
Author
|
Superseded by the Stainless-generated release PR #197, which includes this SDK update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search.contents.fetchTesting
./scripts/buildNote
Medium Risk
Changing
search.contents.fetchfromvoidtoResponseis a public TypeScript breaking change for callers that assumed no body, though it aligns the SDK with the API.Overview
Deferred search content fetch is now typed and documented as a real endpoint:
client.search.contents.fetchreturnsResponse(contents,search_id, usage, warnings) instead ofvoid, andapi.mdreflects that.The
fetchimplementation drops the customAccept: '*/*'header so the client uses normal JSON parsing for the body. JSDoc and generated field comments are rewritten to match the current contract—retained-search retrieval,source/max_age_hours/ browser behavior, per-result outcomes, and cache semantics—replacing the prior “not available / 404” placeholder. The same content-option documentation is synced on inline search create/request types insearch.ts, plus small tweaks toUsage.content_fetchesand deferredResponse.Contentfields (e.g.format,truncated,fetched_at).Reviewed by Cursor Bugbot for commit d08a150. Configure here.