Skip to content

Add Dutch locales to browser images #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tnsardesai wants to merge 1 commit into from
Closed

Add Dutch locales to browser images #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions images/chromium-headful/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked,id=$CACHEIDPREFIX-ap
locales \
tzdata \
unzip && \
locale-gen en_US.UTF-8 en_GB.UTF-8 en_CA.UTF-8 en_IE.UTF-8 en_SG.UTF-8 && \
locale-gen en_US.UTF-8 en_GB.UTF-8 en_CA.UTF-8 en_IE.UTF-8 en_SG.UTF-8 nl_NL.UTF-8 && \
apt-get clean && rm -rf /var/lib/apt/lists/*

# Install fonts to match a realistic Ubuntu 22.04 desktop fingerprint.
Expand Down Expand Up @@ -292,7 +292,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked,id=$CACHEIDPREFIX-ap
libxext6 libxfixes3 libxkbcommon0;

# Install Chrome + ChromeDriver as a matched pair from chrome-for-testing so they cannot drift apart.
# Regional pack filenames preserve each locale identifier while reusing en-GB UI strings.
# Regional pack filenames preserve each locale identifier while reusing base-language UI strings.
ARG CHROME_VERSION=152.0.7977.42
RUN set -eux; \
curl -fsSL "https://storage.googleapis.com/chrome-for-testing-public/${CHROME_VERSION}/linux64/chrome-linux64.zip" -o /tmp/chrome.zip; \
Expand All @@ -302,6 +302,7 @@ RUN set -eux; \
mv /opt/chrome-linux64 /opt/chrome-for-testing; \
mv /opt/chrome-for-testing/chrome /opt/chrome-for-testing/chromium; \
for locale in en-CA en-IE en-SG; do cp /opt/chrome-for-testing/locales/en-GB.pak "/opt/chrome-for-testing/locales/${locale}.pak"; done; \
cp /opt/chrome-for-testing/locales/nl.pak /opt/chrome-for-testing/locales/nl-NL.pak; \
ln -sf /opt/chrome-for-testing/chromium /usr/bin/chromium; \
mv /tmp/chromedriver-linux64/chromedriver /usr/local/bin/chromedriver; \
chmod +x /usr/local/bin/chromedriver /opt/chrome-for-testing/chromium; \
Expand Down
5 changes: 3 additions & 2 deletions images/chromium-headless/image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked,id=$CACHEIDPREFIX-ap
fonts-noto-mono \
fonts-nanum \
supervisor; \
locale-gen en_US.UTF-8 en_GB.UTF-8 en_CA.UTF-8 en_IE.UTF-8 en_SG.UTF-8; \
locale-gen en_US.UTF-8 en_GB.UTF-8 en_CA.UTF-8 en_IE.UTF-8 en_SG.UTF-8 nl_NL.UTF-8; \
fc-cache -f

# sqlite3 for debugging the cookies file; unzip for the chrome-for-testing archives below.
Expand All @@ -174,7 +174,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked,id=$CACHEIDPREFIX-ap
apt-get --no-install-recommends -y install sqlite3 unzip;

# Install Chrome + ChromeDriver as a matched pair from chrome-for-testing so they cannot drift apart.
# Regional pack filenames preserve each locale identifier while reusing en-GB UI strings.
# Regional pack filenames preserve each locale identifier while reusing base-language UI strings.
ARG CHROME_VERSION=152.0.7977.42
RUN set -eux; \
curl -fsSL "https://storage.googleapis.com/chrome-for-testing-public/${CHROME_VERSION}/linux64/chrome-linux64.zip" -o /tmp/chrome.zip; \
Expand All @@ -184,6 +184,7 @@ RUN set -eux; \
mv /opt/chrome-linux64 /opt/chrome-for-testing; \
mv /opt/chrome-for-testing/chrome /opt/chrome-for-testing/chromium; \
for locale in en-CA en-IE en-SG; do cp /opt/chrome-for-testing/locales/en-GB.pak "/opt/chrome-for-testing/locales/${locale}.pak"; done; \
cp /opt/chrome-for-testing/locales/nl.pak /opt/chrome-for-testing/locales/nl-NL.pak; \
ln -sf /opt/chrome-for-testing/chromium /usr/bin/chromium; \
mv /tmp/chromedriver-linux64/chromedriver /usr/local/bin/chromedriver; \
chmod +x /usr/local/bin/chromedriver /opt/chrome-for-testing/chromium; \
Expand Down
Loading