Skip to content

Make 1Password linked-item docs example generic#440

Merged
masnwilliams merged 1 commit into
mainfrom
hypeship/1password-generic-linked-item
Jul 8, 2026
Merged

Make 1Password linked-item docs example generic#440
masnwilliams merged 1 commit into
mainfrom
hypeship/1password-generic-linked-item

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Generalize the "sign in with" linked-item example in the 1Password integration docs so it doesn't name a specific third-party service.

Why

Follow-up to the earlier linked-item clarification — the example should describe the linked-item pattern generically rather than referencing a particular product.

Preview

https://tbd-6fc993ce-hypeship-1password-generic-linked-item.mintlify.app/integrations/1password

Test plan

  • Verify the section renders correctly in Mintlify preview

Note

Low Risk
Documentation copy only; no runtime, API, or credential-handling behavior changes.

Overview
Updates Supported Login Types in the 1Password integration docs so examples stay generic: the direct-login illustration now refers to a Google account only (drops the redundant “Gmail” wording).

The linked-item Warning no longer names PostHog or Google SSO; it describes a site item that sign in with another login, matching the limitation that the 1Password API does not expose those references.

Reviewed by Cursor Bugbot for commit 5e8b74f. Bugbot is set up for automated code reviews on this repo. Configure here.

Replace the specific service name in the "sign in with" example with a
generic description of a linked-item reference.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@masnwilliams masnwilliams marked this pull request as ready for review July 8, 2026 17:54
@masnwilliams masnwilliams merged commit 4d4a0de into main Jul 8, 2026
3 checks passed
@masnwilliams masnwilliams deleted the hypeship/1password-generic-linked-item branch July 8, 2026 17:54

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk assessment: Very Low.

Evidence from the diff: this PR only edits two user-facing documentation sentences in integrations/1password.mdx to make the 1Password linked-item example more generic. It doesn't change application code, prompts, docs navigation, infrastructure, auth/permissions, or generated assets. I also found no CODEOWNERS file and no existing reviews on the PR, so approval is appropriate under the Very Low risk rule.

Open in Web View Automation 

Sent by Cursor Automation: Assign PR reviewers

@mintlify

mintlify Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Kernel 🔴 Failed Jul 8, 2026, 5:58 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant