Repository navigation
CLI: Update Go SDK to 738369d524a3806832577f6793dde7eaf15c5725 - #304
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1f9ef54 to
8296665
Compare
save-profile now prints whether it created or overwrote the profile, and no longer lets the SDK retry: a retry after a failed or slow save starts a second save and restarts the browser again. The help text names browser_not_active, mentions Playwright connections, and says to save at a stable point.
hiroTamada
left a comment
There was a problem hiding this comment.
reviewed — the vault no-replay middleware is a real fix (verified both subtests fail with writes=2 without it), and the new surfaces look well-guarded. a couple of questions, neither blocking:
Questions
cmd/browsers.go:1109— save-profile restarts the browser but uses default SDK retries (2x on 409/5xx/conn errors). help says "retry only browser_busy", but the SDK will also auto-retry browser_lease_changed/inactive 409s. consideroption.WithMaxRetries(0)or confirm the API sendsx-should-retry: falsecmd/vaults_commands.go:498-537— does the API accept PATCH on a KERNEL payment_request?cards updateexcludes kernel ("kernel cards cannot be updated", :466), butpayment-requests updateallows--provider kerneland its example (shared with create, :515) shows a KERNEL spec. if unsupported, mirror cards update; if supported, the "same lifecycle as the card" help needs a caveat
bmsaadat
left a comment
There was a problem hiding this comment.
Holding this until the Shop Pay changes pass a smoke test through the real API (Raf's ask for the SDK bot PRs). The approval above predates the Shop Pay commits. I'll approve as soon as it passes.
bmsaadat
left a comment
There was a problem hiding this comment.
Smoke tested the Shop Pay changes against the prod API with a local build of this branch: wallet connect, card create, spec refusals, authorize at checkout, Shop approval, fill, a real $1 purchase on Kernel's Stripe link, and confirm_transaction (card consumed). All passed.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6fdc7e5. Configure here.
| } | ||
| } | ||
| if op.Type == "authorize" && item.Type == "card" && item.Spec.Provider == "link" && item.State.Status == "requested" { | ||
| if op.Type == "authorize" && (item.Type == "card" || item.Type == "payment_request") && item.Spec.Provider == "link" && item.State.Status == "requested" { |
There was a problem hiding this comment.
Shop Pay authorize hint omits flags
Low Severity
printVaultOperationHints appends --browser-id and --page-url only for requested Link card or payment_request authorize. Requested Shop Pay cards now accept the same checkout-bound pair, so the printed invoke line sends users down the merchant_url path instead of locking fill to the open checkout.
Reviewed by Cursor Bugbot for commit 6fdc7e5. Configure here.


Summary
738369d524a3806832577f6793dde7eaf15c5725.Coverage
CLI coverage update report
SDK update
github.com/kernel/kernel-go-sdkfromv0.137.0tov0.138.0(SDK commit738369d524a3806832577f6793dde7eaf15c5725).go get github.com/kernel/kernel-go-sdk@738369d524a3806832577f6793dde7eaf15c5725andgo mod tidy.Coverage audit
api.mdand reviewed their parameter structs.x-cli-skip: true:client.ConfigRegistry.Listclient.ConfigRegistry.Lookupclient.ConfigRegistry.Resolveclient.ConfigRegistry.Analyses.Getclient.ConfigRegistry.Analyses.Listclient.ConfigRegistry.Analyses.CancelGap analysis
Missing commands
Missing flags
Changes
Commands and flags
Response output
SDK
v0.138.0adds the browser-session response fieldleased_at. Following OpenAPI fieldcomponents.schemas.Browser.leased_at, the CLI now shows Leased At for leased pooled sessions in human-readable output from:kernel browsers createwhen acquiring through--pool-idor--pool-namekernel browsers getkernel browsers updatekernel browsers list(column shown only when at least one result is leased)kernel browser-pools acquirekernel invoke browsers(column shown only when at least one result is leased)JSON output already includes
leased_atthrough the updated SDK response models. No command Short/Long text or flag usage text needed adjustment because this release changes only a response field, not endpoint or request-field behavior.Intentional exclusions
x-cli-skip: true.x-cli-skip: trueare not exposed as methods in this SDK release and therefore require no CLI command.Validation
go test ./cmd/... ./pkg/...— passed.go build ./...— passed./home/runner/work/_temp/cli-scratch/kerneland smoke-checked help for the affected commands.leased_atvalues.Validation
Note
High Risk
Changes span payment vault operations, API key policy issuance, and browser save-profile (session restart), all security- and money-sensitive paths with new validation and concurrency semantics.
Overview
Updates the CLI for kernel-go-sdk v0.138.0, wiring new request fields and response metadata across several command groups—not only pooled-session
leased_atdisplay.API keys gain
--expires-at(RFC3339, mutually exclusive with--days-to-expire) and--policyJSON for least-privilege statements; list/get/sort now surface Last Used At with docs on ~20-minute accuracy.Managed auth connections add
--hitlon create/update to pause unsolved login CAPTCHAs for live-view completion, plus Live View URL infollowoutput and expandedsubmithelp forhuman_interventionchoices.Browsers add
save-profile, closed-beta--fingerprint-os=macos, conditional allowlist updates via--expected-allowlist-revision+--mutation-id, and Leased At in create/get/list/update and pool-acquire paths when applicable. Browser pool update accepts--expected-networkfor optimistic concurrency on network changes.Vaults expand payment coverage: Shop Pay wallets/cards,
payment-requestscreate/update for Link/KERNEL one-purchase items,add_payment_method/remove_payment_method, richerconfirm_transactionparsing (order/failure fields, Shop Pay transaction-type limits), and broader authorize/fill/recovery behavior for Link payment requests and Shop Pay. Vault writes route through sharedvaultWriteRequestOptions()(no retries) instead of ad hocWithMaxRetries(0).Reviewed by Cursor Bugbot for commit 6fdc7e5. Bugbot is set up for automated code reviews on this repo. Configure here.