Clarify Link fill-only checkout guidance - #255
Merged
Merged
Conversation
hiroTamada
marked this pull request as ready for review
September 16, 2026 14:31
rgarcia
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing formatter and fill request plumbing already support these response and operation contracts. No SDK, dependency, or generated-file changes.
Validation
All commands below passed with
GOCACHE=/tmp/cli-go-build(the default cache directory was not writable):go test ./cmd -run 'Test(Vault|Credential)' -count=1make test(go vet ./...andgo test ./...)go test ./... -count=1 -json: 1,533 passing test/subtest results, no skipped tests; four packages have no test files.make buildkernel vaults items invoke --helpoutput.git diff main...HEAD;git diff --check main...HEADpassed.No live checkout or production mutation tests were run.
Note
Low Risk
Documentation, CLI help, and test-only changes with no SDK or payment execution logic modified in the diff.
Overview
Updates README and
kernel vaults/items get/items invokehelp so payment checkout guidance matches provider boundaries: Link browser checkout isfillonly (vault must be attached), with nostate.aliasesor egress substitution; AgentCard-only aliases remain the separate hold/approval/replay integration and are not a fallback after failed fill.Documentation also spells out
fillsemantics more explicitly—real values land in the browser (CDP-readable), forms are not explicitly submitted, partial/unknownoutcomes stay non-retry, andcompleted≠ paid.Tests split alias output coverage into AgentCard vs Link fixtures, add
TestVaultOutputLinkHasNoAliases, and lock help text withTestVaultPaymentHelpProviderBoundariesso old “aliases as alternative” wording cannot regress.Reviewed by Cursor Bugbot for commit 2f989e4. Bugbot is set up for automated code reviews on this repo. Configure here.