Skip to content

Preserve public credential values and clarify fill errors - #254

Merged
rgarcia merged 1 commit into
mainfrom
hypeship/vault-public-values
Sep 16, 2026
Merged

rgarcia merged 1 commit into
mainfrom
hypeship/vault-public-values

Conversation

@rgarcia

@rgarcia rgarcia commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Return explicitly non-sensitive text/email values in credential JSON output across create, update, get, list, and collect. Sensitive values, TOTP seeds, missing sensitivity flags, and unknown fields remain protected. Preserve collection URLs.
  • Give fill API errors actionable explanations alongside HTTP status and allowlisted codes. Documented pre-write rejections (400/403/404/409) state that this request wrote no fields; transport loss and other uncertain failures retain no-retry guidance. Raw upstream details remain hidden.
  • Let the API validate type-specific fields, formats, destinations, and selector limits rather than duplicating policy in the CLI. Retain structural JSON validation, size limits, advertised-operation checks, safe result projection, and zero SDK retries.
  • Update help/README and add public-value and meaningful-error regression coverage.

Validation

  • make test (go vet and all tests): passed
  • make build: passed
  • Focused vault public-value and fill-error tests under the race detector: passed
  • Existing subprocess tests still verify one attempt and safe stdout/stderr behavior for errors and uncertain outcomes.
  • No live API/browser/payment operations performed. No release included.

@masnwilliams masnwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. the public-value projection is fail-closed and the tests cover sensitive, TOTP, unknown, and missing-metadata cases. delegating item-specific fill policy to the API removes duplicated validation, and the new guidance matches the API's pre-write error contract.

non-blocking follow-up: preflight item retrieval failures still return the generic could not retrieve vault item message, so missing vault/item errors do not benefit from the new status/code guidance.

@rgarcia
rgarcia merged commit 2242ce5 into main Sep 16, 2026
8 checks passed
@rgarcia
rgarcia deleted the hypeship/vault-public-values branch September 16, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants