Repository navigation
Feat/label qr and tailscale - #563
Open
Brandon2255p wants to merge 6 commits into
Open
Brandon2255p wants to merge 6 commits into
Brandon2255p wants to merge 6 commits into
Conversation
Helpers copied between modules now live in one place, unchanged in behaviour: - purchases uses money/input.ts's amountIn, currencyIn, requireEnabled, todayIn and moneyOff instead of its own copies; schedules re-exports todayIn from there, and money/input.ts re-exports things/validate.ts's moneyOff. - safeTimeZone, copied into four report views and the incident report, is reports/locale.ts's. - requireVersion, copied into fuel, schedules, service records and things, is audit/undo.ts's requireRowVersion(client, entityType, ...). - optionalIfMatch, identical in meters, things and moves, is http/conventions.ts's. places/routes.ts keeps its own: it also treats an empty If-Match as absent.
A label's QR holds `<public-url>/l/<code>`, so a long domain makes a dense QR: 29 modules a side for a tailnet name, 33 for a longer domain. The print screen now asks what the QR holds: the link (the default, any phone camera opens it) or the code alone, 21 modules, the smallest QR there is. Only Kept's scanner reads that one; shared/scan.ts already takes a bare code as a Kept label, so labels of both kinds keep working. The choice is remembered on this browser, like the stock, and shown only for stocks that print a QR. The sheet, its preview and the phone PNGs all follow it. Five strings, in every catalogue.
compose.yaml with no published port: Kept is reachable only through a tailscale service that serves it over HTTPS on the tailnet, with a Tailscale certificate and Funnel off. Serve proxies to the kept-app alias and the tailscale container has no hostname, so the proxy cannot resolve to itself and loop. The kept service also gets the owner URL and the kept-owner volume (read-only) for the nightly backup. A separate file, so compose.yaml and compose.full.yaml stay as they are.
fork-image.yml builds the Dockerfile's runtime target for amd64 and arm64 and pushes ghcr.io/<owner>/kept, so an install runs the fork with KEPT_IMAGE in .env. Tags: the branch, sha-<commit>, and latest from main. The version is upstream's last release with the commit as build metadata (1.14.7+fork.abc1234), and the image's source labels name this fork. Skipped in keptinventory/kept, which publishes through release.yml.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
release_history_version_chk takes a prerelease and refuses a +, so an image versioned 1.14.7+fork.<commit> failed kept migrate as it recorded the release, and kept, waiting on migrate, never started. Fork images are now <next patch>-fork.<commit> (1.14.8-fork.abc1234): after the release they are built on, before upstream's next.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Checks
bash scripts/ci-local.shpasses (or--fast, and say which steps you couldn't run)