ci: allow merging chart changes without a version bump - #94
Merged
Conversation
`ct lint` enforced a version increment on every pull request touching the chart, so each merge had to ship a chart release. Disable the check. A merge without a bump must not break the release job either. chart-releaser picks changed charts by diffing the latest tag against HEAD rather than by comparing versions, so it repackages the unchanged version and aborts on the already existing release. Pass `skip_existing` so the upload is skipped, the published release stays untouched, and the changes ship with the next bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request should be mergeable without bumping the chart version. The change then simply is not released, and ships with the next bump. Requiring a bump per pull request forces a chart release for every merge.
ct lintno longer requires a bumpcheck-version-incrementdefaults to true, which is what fails #93 today:Disabled in
.github/ct.yaml. Everything elsect lintdoes (helm lint, yamllint,Chart.yamlvalidation, schema checks) is unaffected.chart-releaserskips the already released versionThis half is needed to keep the first half from just moving the failure to
main.chart-releaser-actionselects charts by diffing the latest tag against HEAD, not by comparing versions, so a merge that touchescharts/without a bump still counts as changed: it repackages6.1.7and tries to upload it, and the releasekellnr-6.1.7already exists. Withoutskip_existingthat aborts the release job.With
skip_existing: truethe upload is skipped, the published release is left untouched, and nothing new is created.Verification
Ran
ct3.14.0 locally, the same version the CI job uses:Version increment checking disabled.thenAll charts linted successfully.main'sChart.yaml, which feat(kellnr): configure additional OAuth2 audiences #93 does not touch) andct lintpasses. So this unblocks feat(kellnr): configure additional OAuth2 audiences #93 without a bump.Both changed YAML files parse.
Note
Releases now need a deliberate bump. Nothing prompts for one any more, so chart changes merged without a bump stay unreleased until the next
repository_dispatchfrom a kellnr release bumps the patch and ships everything accumulated since.