Conversation
setCookie fell back to a hardcoded DEFAULT_TOKEN_LIFE of 14 days when no expiration was supplied. With the login token lifetime moving from two weeks to four weeks, that fallback would silently keep cookies at the old 14-day value. The production login and logout paths already pass an explicit expires sourced from the auth service, so they are unaffected. The only caller relying on the fallback was the localhost dev token-injection dialog. - Remove DEFAULT_TOKEN_LIFE and require an integer expires in setCookie (throws otherwise), so cookie expiry must always come from the auth service rather than a hardcoded client-side lifetime. - Dev token-injection dialog now fetches the token's real expiration via getTokenInfo and passes it through; invalid tokens are reported. - Update authSpec setCookie call to pass an explicit expires.
Update gha
…2026' into dep-updates-july-2026
Update dependencies and fix tests (part 1)
Dependency updates + Integration tests (part 2)
Dep updates july 2026 - Python (part 3)
Remove non-functional integration test GHA workflow and references to it
Remove hardcoded 14-day token lifetime from auth cookie handling
PTV-1930 fix datatable error when data is missing from FeatureClusters object
Update version to 5.5.1
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - | ||
| name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@master | ||
| uses: docker/setup-buildx-action@v4 |
| - | ||
| name: Log in to the Container registry | ||
| uses: docker/login-action@master | ||
| uses: docker/login-action@v4 |
| - | ||
| name: Build narrative image | ||
| uses: docker/build-push-action@master | ||
| uses: docker/build-push-action@v7 |
| name: Build version image | ||
| uses: docker/build-push-action@master | ||
| if: ${{ github.base_ref }} == 'main' || ${{ github.base_ref }} == 'develop' | ||
| uses: docker/build-push-action@v7 |
| - | ||
| name: Log in to the Container registry | ||
| uses: docker/login-action@master | ||
| uses: docker/login-action@v4 |
| - | ||
| name: Log in to the Container registry | ||
| uses: docker/login-action@master | ||
| uses: docker/login-action@v4 |
| name: Send to Codecov | ||
| id: send_to_codecov | ||
| uses: codecov/codecov-action@main | ||
| uses: codecov/codecov-action@v7 |
|
|
||
| WORKDIR /kb/dev_container/narrative | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | bash - && \ |
|
|
||
| WORKDIR /kb/dev_container/narrative | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | bash - && \ |
| WORKDIR /kb/dev_container/narrative | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | bash - && \ | ||
| apt-get install -y nodejs |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 25.96% 25.95% -0.02%
==========================================
Files 461 461
Lines 46691 46701 +10
==========================================
- Hits 12122 12119 -3
- Misses 34569 34582 +13
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ialarmedalien
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.