fix(adk): extract text from MCP embedded resource content blocks - #2541
Open
mesutoezdil wants to merge 4 commits into
Open
fix(adk): extract text from MCP embedded resource content blocks#2541mesutoezdil wants to merge 4 commits into
mesutoezdil wants to merge 4 commits into
Conversation
extractFunctionResponseContent only read the top-level text field on each content item, so type: resource blocks (text nested under resource.text) were silently dropped from what the model sees. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…urce-content Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…urce-content Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…urce-content Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractFunctionResponseContent only reads the top-level text field on each MCP content item. Embedded resource blocks (type: resource) carry their text under resource.text instead, so those blocks were silently dropped and the model never saw that part of the tool result. Falls back to resource.text when no top-level text field is present.