feat(helm): add support for custom agent image registry and repository in controller configuration - #2530
Open
entee28 wants to merge 2 commits into
Open
Conversation
… values --image-digest has no build-time equivalent today: scripts/controller-digest-ldflags.sh, which would stamp AgentImageDigest via ldflags, is never invoked by `make build-controller` or any CI workflow -- confirmed true for upstream's own official build too, not just a fork-specific gap. Until that's wired in, expose --image-digest as a Helm-configurable controller arg so Declarative SandboxAgent compilation can succeed at all. Signed-off-by: Thanh Nguyen <puffle.nnt@gmail.com>
…y in controller configuration agentImageRegistry/agentImageRepository let the golang-adk runtime image (used for every declarative SandboxAgent) be pointed at a build other than the compiled-in default (ghcr.io/kagent-dev/kagent/golang-adk) -- e.g. a fork's own release -- via the controller's --image-registry/--image-repository flags. Signed-off-by: Thanh Nguyen <puffle.nnt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2529