fix(substrate): mirror ActorTemplate CRD defaults to stop infinite recreate loop - #2528
Open
entee28 wants to merge 2 commits into
Open
fix(substrate): mirror ActorTemplate CRD defaults to stop infinite recreate loop#2528entee28 wants to merge 2 commits into
entee28 wants to merge 2 commits into
Conversation
…t spec drift ActorTemplateSpec.ContainerReadyz.TimeoutSeconds has a non-zero +kubebuilder:default (30) but is a non-pointer field, so an unset value here serializes as 0 and permanently disagrees with the apiserver's defaulted stored value, causing reconcileActorTemplate to treat it as spec drift and loop deleting/recreating the ActorTemplate forever. Signed-off-by: Thanh Nguyen <puffle.nnt@gmail.com>
…ate loop Same class of bug as ContainerReadyz.TimeoutSeconds: SnapshotsConfig.OnResume is a non-pointer struct with a non-zero +kubebuilder:default (ColdBoot), so leaving it unset in both the SandboxAgent and AgentHarness ActorTemplate builders left the desired spec permanently disagreeing with the apiserver-defaulted stored spec, keeping the delete+recreate loop going even after the TimeoutSeconds fix alone. Signed-off-by: Thanh Nguyen <puffle.nnt@gmail.com>
entee28
changed the title
github-actions
Bot
added
bug
Contributor
|
Gonna hold off merging this as this API will be moving into the substrate API server soon: agent-substrate/substrate#1096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2527