test: add missing unit tests for adk and core packages - #2520
Open
yashrajshuklaaa wants to merge 4 commits into
Open
test: add missing unit tests for adk and core packages#2520yashrajshuklaaa wants to merge 4 commits into
yashrajshuklaaa wants to merge 4 commits into
Conversation
… reconciler, reconciler utils Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
yashrajshuklaaa
force-pushed
the
chore/add-missing-tests
branch
2 times, most recently
from
August 22, 2026 00:10
bff00a2 to
c06a3f0
Compare
mesutoezdil
reviewed
Aug 24, 2026
| assert.True(t, serviceerrors.IsCode(err, serviceerrors.CodePermissionDenied)) | ||
| } | ||
|
|
||
| func assertAnError() error { |
Contributor
There was a problem hiding this comment.
name says assert, but this just builds an error. confusing name.
| Spec: v1alpha3.SandboxAgentSpec{ | ||
| Type: v1alpha3.AgentType_Declarative, | ||
| Declarative: &v1alpha3.DeclarativeAgentSpec{ | ||
| // ModelConfig deliberately omitted / points at a ModelConfig |
Contributor
There was a problem hiding this comment.
comment says omitted, but code sets it to a missing name. pick one wording.
Contributor
Author
There was a problem hiding this comment.
resolved! thanks for the suggestion.
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
…CreateRunnerConfig via mockllm) Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
yashrajshuklaaa
force-pushed
the
chore/add-missing-tests
branch
from
August 25, 2026 03:33
c06a3f0 to
baa973f
Compare
Contributor
Author
|
@EItanya PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only change adding unit test coverage for -
go/adk/pkg/auth/token_test.gogo/adk/pkg/runner/adapter_test.go(+testdata/config_openai.json,testdata/mock_openai.json)go/core/internal/controller/reconciler/status/mcp_server_test.gogo/core/internal/controller/reconciler/utils/reconciler_utils_test.gogo/core/internal/controller/translator/mutate_test.gogo/core/internal/service/agent/service_test.gogo/core/internal/service/agent/validator_test.goNo production code changes.
All tests pass locally (
go test ./...)