Harden ContextZIP path and filename safety - #2
Draft
junjunjunbong wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.contextzipWhy
Custom manifest paths were resolved without the same containment checks as output paths, so a user-supplied path could escape
.contextzip, overwrite a project file, or place the manifest inside the upload folder. Collision suffixes were also appended after the filename length check, which could produce names longer than the declared 240-byte limit.Impact
Default pack behavior remains unchanged. Unsafe or overlapping custom paths now fail before filesystem mutation, and long or colliding filenames remain deterministic and upload-safe.
Validation
python -m unittest discover -s tests -von Python 3.10.20: 23 passedpython -m unittest discover -s tests -von Python 3.12.13: 23 passedgit diff --check.env*exclusion