Repository navigation
Fix SCS test tolerances in test_JuMP.jl - #243
Merged
Merged
Conversation
The SCS tests checked answers to 1e-5 while SCS ran at its default tolerance of 1e-4, so they broke when SCS_jll 3.3.1 landed slightly further away. Tighten eps_abs/eps_rel to 1e-9 in the four failing tests and replace solver output pasted as expected values (-2.9999734, 0.7499854, ...) with the exact answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 99.84% 99.85% +0.01%
==========================================
Files 10 10
Lines 1947 2102 +155
==========================================
+ Hits 1944 2099 +155
Misses 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.